Closed
Bug 1239426
Opened 9 years ago
Closed 9 years ago
eslint components-import rule does not handle arrow functions
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox46 fixed)
RESOLVED
FIXED
mozilla46
| Tracking | Status | |
|---|---|---|
| firefox46 | --- | fixed |
People
(Reporter: tromey, Assigned: tromey)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
miker
:
review+
|
Details | Diff | Splinter Review |
For devtools/server/actors/styles.js I am seeing eslint reports like
"DOMUtils is not defined" in various spots. However DOMUtils is defined as:
loader.lazyGetter(this, "DOMUtils", () => {
return Cc["@mozilla.org/inspector/dom-utils;1"].getService(Ci.inIDOMUtils);
});
I tracked the problem down to getASTSource not handling arrow functions.
|
Assignee | |
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8707585 -
Flags: review?(mratcliffe)
Comment on attachment 8707585 [details] [diff] [review]
handle arrow functions in getASTSource
Review of attachment 8707585 [details] [diff] [review]:
-----------------------------------------------------------------
I had been planning on looking at this so thanks for the fix!
Attachment #8707585 -
Flags: review?(mratcliffe) → review+
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•